Commit-ID: 61be3e59ba7a6dbd39f92fd1f107285a0caeb008
Gitweb: http://git.kernel.org/tip/61be3e59ba7a6dbd39f92fd1f107285a0caeb008
Author: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
AuthorDate: Mon, 28 Dec 2009 16:48:30 +0800
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Mon, 28 Dec 2009 10:36:36 +0100
perf trace: Clean up find_debugfs()
Remove redundant code for 'perf trace'
Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Clark Williams <williams@xxxxxxxxxx>
Cc: John Kacur <jkacur@xxxxxxxxxx>
LKML-Reference: <4B3870DE.7090500@xxxxxxxxxxxxxx>
[ v2: resolved conflicts with recent changes ]
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
tools/perf/util/debugfs.c | 1 +
tools/perf/util/trace-event-info.c | 29 +++++------------------------
2 files changed, 6 insertions(+), 24 deletions(-)
diff --git a/tools/perf/util/debugfs.c b/tools/perf/util/debugfs.c
index 1f805fd..a88fefc 100644
--- a/tools/perf/util/debugfs.c
+++ b/tools/perf/util/debugfs.c
@@ -130,6 +130,7 @@ char *debugfs_mount(const char *mountpoint)
/* save the mountpoint */
strncpy(debugfs_mountpoint, mountpoint, sizeof(debugfs_mountpoint));
+ debugfs_found = 1;
return debugfs_mountpoint;
}
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index dfef238..535176d 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -38,6 +38,7 @@
#include "../perf.h"
#include "trace-event.h"
+#include "debugfs.h"
#define VERSION "0.5"
@@ -102,32 +103,12 @@ void *malloc_or_die(unsigned int size)
static const char *find_debugfs(void)
{
- static char debugfs[MAX_PATH+1];
- static int debugfs_found;
- FILE *fp;
- struct mntent *m;
-
- if (debugfs_found)
- return debugfs;
-
- fp = setmntent("/proc/mounts", "r");
- if (!fp)
- die("Can't open /proc/mounts for read");
-
- while ((m = getmntent(fp)) != NULL) {
- if (strcmp(m->mnt_type, "debugfs") == 0) {
- strcpy(debugfs, m->mnt_dir);
- debugfs_found = 1;
- break;
- }
- }
-
- endmntent(fp);
+ const char *path = debugfs_mount(NULL);
- if (!debugfs_found)
- die("debugfs not mounted, please mount");
+ if (!path)
+ die("Your kernel not support debugfs filesystem");
- return debugfs;
+ return path;
}
/*
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|