Hi, tip-bot for akpm@xxxxxxxxxxxxxxxxxxxx wrote: > Commit-ID: 8c63450718ea62ee3a70bffde170b4d15fc72d3c > Gitweb: http://git.kernel.org/tip/8c63450718ea62ee3a70bffde170b4d15fc72d3c > Author: akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx> > AuthorDate: Thu, 17 Dec 2009 15:26:36 -0800 > Committer: H. Peter Anvin <hpa@xxxxxxxxx> > CommitDate: Thu, 17 Dec 2009 15:34:29 -0800 > > x86: Fix objdump version check in arch/x86/tools/chkobjdump.awk > > It says > > Warning: objdump version is older than 2.19 > Warning: Skipping posttest. > > because it used the wrong field from `objdump -v': > > akpm:/usr/src/25> /opt/crosstool/gcc-4.0.2-glibc-2.3.6/x86_64-unknown-linux-gnu/bin/x86_64-unknown-linux-gnu-objdump -v > GNU objdump 2.16.1 > Copyright 2005 Free Software Foundation, Inc. > This program is free software; you may redistribute it under the terms of > the GNU General Public License. This program has absolutely no warranty. Oh, I didn't know that. On my environment, objdump shows version in below format. --- $ objdump -v GNU objdump version 2.19.51.0.14-1.fc11 20090722 Copyright 2008 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License version 3 or (at your option) any later version. This program has absolutely no warranty. --- Hmm, maybe, we need to check if ($3 == "version") to decide which argument we should use. Thank you, > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Ingo Molnar <mingo@xxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > LKML-Reference: <200912172326.nBHNQaQl024796@xxxxxxxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx> > Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx> > --- > arch/x86/tools/chkobjdump.awk | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/tools/chkobjdump.awk b/arch/x86/tools/chkobjdump.awk > index 0d13cd9..5bbb5a3 100644 > --- a/arch/x86/tools/chkobjdump.awk > +++ b/arch/x86/tools/chkobjdump.awk > @@ -9,7 +9,7 @@ BEGIN { > } > > /^GNU/ { > - split($4, ver, "."); > + split($3, ver, "."); > if (ver[1] > od_ver || > (ver[1] == od_ver && ver[2] >= od_sver)) { > exit 1; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html