Frederic Weisbecker wrote:
>
> Except for this patch. The whole series is really nice, thanks
> a lot for this cleanup!
>
>
>
> But I think you fixed it the wrong way.
>
> Why do we need a copy of this event_syscall_enter
> for each syscall event?
> Can't we actually drop enter_syscall_print_##sname
> and always use event_syscall_enter instead?
>
> The same applies to exit syscall events.
>
> Thanks.
>
64c12e0444fcc6b75eb49144ba46d43dbdc6bc8f is a nice patch from
Jason Baron, this patch introduces enter_syscall_print_##sname.
This patch only forgot to do some cleanups. My patch make up it:
fix event_enter_##sname->event
fix event_exit_##sname->event
remove unused event_syscall_enter and event_syscall_exit
Thanks,
Lai
commit 64c12e0444fcc6b75eb49144ba46d43dbdc6bc8f
Author: Jason Baron <jbaron@xxxxxxxxxx>
Date: Mon Aug 10 16:52:53 2009 -0400
tracing: Add individual syscalls tracepoint id support
The current state of syscalls tracepoints generates only one event id
for every syscall events.
This patch associates an id with each syscall trace event, so that we
can identify each syscall trace event using the 'perf' too
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|