Re: [tip:x86/debug] x86: Minimise printk spew from per-vendor init code
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/debug] x86: Minimise printk spew from per-vendor init code
- From: Dave Jones <davej@xxxxxxxxxx>
- Date: Fri, 13 Nov 2009 20:38:56 -0500
- Cc: mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <86802c440911131703y35520496pfbdaa4e0bd8f8609@xxxxxxxxxxxxxx>
- Mail-followup-to: Dave Jones <davej@xxxxxxxxxx>, Yinghai Lu <yhlu.kernel@xxxxxxxxx>, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- References: <20091113203000.GA19160@xxxxxxxxxx> <tip-0388423dba2217b4e5b6c61690b0506d13b25a49@xxxxxxxxxxxxxx> <86802c440911131703y35520496pfbdaa4e0bd8f8609@xxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.20 (2009-08-17)
On Fri, Nov 13, 2009 at 05:03:44PM -0800, Yinghai Lu wrote:
> > --- a/arch/x86/kernel/cpu/common.c
> > +++ b/arch/x86/kernel/cpu/common.c
> > @@ -656,6 +656,7 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
> >
> > void __init early_cpu_init(void)
> > {
> > +#ifdef PROCESSOR_SELECT
> > const struct cpu_dev *const *cdev;
> > int count = 0;
> >
> > @@ -676,7 +677,7 @@ void __init early_cpu_init(void)
> > cpudev->c_ident[j]);
> > }
> > }
> > -
> > +#endif
> > early_identify_cpu(&boot_cpu_data);
> > }
>
> NACK.
>
> the function is initializing cpu_devs array.
Ugh, I don't know how I missed that. I also seem to have boot tested the wrong kernel.
Back to the drawing board.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]