On Tue, Nov 10, 2009 at 03:06:20PM -0800, Joe Perches wrote: > On Tue, 2009-11-10 at 14:59 -0800, Paul E. McKenney wrote: > > > non-inline functions in .h files probably aren't a good idea. > > ;-) > > Here are my options: > [] > > Please note that kernel/rcutree_plugin.h is internal to RCU -- only > > kernel/rcutree.c includes it, so there is no possibility of conflicting > > definitions. > > > > Any options that I am missing? > > Maybe something like: > > #ifdef whatever > #define RCU_ANNOUNCE "Hierarchical RCU implementation.\n" > ... > #else > #define RCU_ANNOUNCE "Experimental preemptable hierarchical RCU implementation.\n" > ... > #endif > > Use pr_info(RCU_ANNOUNCE) instead of rcu_bootup_announce(); > > ? This would still be a forward reference, right? Unless I am missing something, changing from a static inline to a cpp macro doesn't change anything. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|