Commit-ID: d70a5402f9c2e2671b809363616b3508b4c5a565
Gitweb: http://git.kernel.org/tip/d70a5402f9c2e2671b809363616b3508b4c5a565
Author: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
AuthorDate: Fri, 30 Oct 2009 16:28:25 -0200
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Mon, 2 Nov 2009 16:52:12 +0100
perf tools: Improve message about missing symtabs for deleted DSOs
Instead of:
no symbols found in /usr/lib/gstreamer-0.10/libgsttypefindfunctions.so (deleted), maybe install a debug package?
no symbols found in /usr/lib/gstreamer-0.10/libgstaudioconvert.so (deleted), maybe install a debug package?
We now emit:
/usr/lib/gstreamer-0.10/libgsttypefindfunctions.so was updated, restart the long running apps that use it!
/usr/lib/gstreamer-0.10/libgstaudioconvert.so was updated, restart the long running apps that use it!
Which is far less misleading about what the cause of the
symbol mismatch is.
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
LKML-Reference: <1256927305-4628-3-git-send-email-acme@xxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
tools/perf/util/map.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 679011c..f1e2169 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -75,6 +75,8 @@ out_delete:
return NULL;
}
+#define DSO__DELETED "(deleted)"
+
struct symbol *
map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter)
{
@@ -86,8 +88,18 @@ map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter)
self->dso->long_name);
return NULL;
} else if (nr == 0) {
- pr_warning("No symbols found in %s, maybe install a debug package?\n",
- self->dso->long_name);
+ const char *name = self->dso->long_name;
+ const size_t len = strlen(name);
+ const size_t real_len = len - sizeof(DSO__DELETED);
+
+ if (len > sizeof(DSO__DELETED) &&
+ strcmp(name + real_len + 1, DSO__DELETED) == 0)
+ pr_warning("%.*s was updated, restart the "
+ "long running apps that use it!\n",
+ real_len, name);
+ else
+ pr_warning("no symbols found in %s, maybe "
+ "install a debug package?\n", name);
return NULL;
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|