> > > > OK, I'll bite. We tell userspace developers not to include kernel > > headers. Why is it okay for perf to do it (especially for something > > that's in asm)? > > The main counter-argument against inclusion was always "what if we break > them accidentally". I.e. it can become a semi-ABI - stuff we cannot > change because we cannot change the outside projects. With perf this > cannot occur - it's all in one Git tree and can always be fixed/changed. > > Note that we reuse a couple of other facilities in tools/perf as well - > linux/list.h, rbtree.c, etc. - and this is good - you can code perf as > if you were hacking on the kernel! ;-) I see no reasons why perf should not use the exported headers in the default case. unistd.h from alpha is indeed exported. If perf then on top of that uses some kernel internal stuff - then pick it up there. But having perf in the kernel is not an excuse for avoinding the exported headers. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|