Re: [PATCH 0/1] kthreads: simplify !kthreadd_task logic, kill kthreadd_task_init_done
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 0/1] kthreads: simplify !kthreadd_task logic, kill kthreadd_task_init_done
- From: Oleg Nesterov <oleg@xxxxxxxxxx>
- Date: Sat, 19 Sep 2009 01:22:15 +0200
- Cc: Wu Fei <at.wufei@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, arjan@xxxxxxxxxxxxx, jeremy@xxxxxxxx, mschmidt@xxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tj@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>
- In-reply-to: <alpine.LFD.2.01.0909181504400.4950@xxxxxxxxxxxxxxxxxxxxx>
- References: <20090901145526.GA31317@xxxxxxxxxx> <20090901165235.GA9105@xxxxxxxxxx> <m13a76xnbw.fsf@xxxxxxxxxxxxxxxxx> <20090902091340.GA5173@xxxxxxxxxx> <20090904073749.GB20598@xxxxxxx> <20090918163241.GA8556@desktop> <20090918185425.GA16620@xxxxxxxxxx> <alpine.LFD.2.01.0909181217270.4950@xxxxxxxxxxxxxxxxxxxxx> <20090918211218.GA19351@xxxxxxxxxx> <alpine.LFD.2.01.0909181504400.4950@xxxxxxxxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.18 (2008-05-17)
On 09/18, Linus Torvalds wrote:
>
> As to why pid == 0 wouldn't work, I don't know, but I'll take your word
> for it.
Say, admin wants to renice kthreadd or change its affinity. And we can't
show kthread in /proc if its pid is 0.
This can be changed afaics, we can even remove pidmap_init()->set_bit(0) so
that the first copy_process()->alloc_pid() will create the pid with nr == 0.
We don't care about unhashed init_struct_pid which also has nr == 0.
But I don't think this would be good, currently the code can safely assume
that the valid pid can't be 0. For example, find_process_by_pid(0) returns
current.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]