* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 03 Sep 2009 15:57:54 -0700 > "H. Peter Anvin" <hpa@xxxxxxxxx> wrote: > > > On 09/03/2009 03:55 PM, Andrew Morton wrote: > > > On Mon, 31 Aug 2009 09:50:09 +0200 > > > Borislav Petkov <petkovbb@xxxxxxxxxxxxxx> wrote: > > > > > >> +.macro op_safe_regs op:req > > > > > > Using > > > > > > GNU assembler 2.16.1 > > > > > > I get > > > > > > arch/x86/lib/msr-reg.S: Assembler messages: > > > arch/x86/lib/msr-reg.S:53: Error: Bad macro parameter list > > > arch/x86/lib/msr-reg.S:100: Error: invalid character '_' in mnemonic > > > arch/x86/lib/msr-reg.S:101: Error: invalid character '_' in mnemonic > > > > > > this: > > > > > > diff -puN arch/x86/lib/msr-reg.S~a arch/x86/lib/msr-reg.S > > > --- a/arch/x86/lib/msr-reg.S~a > > > +++ a/arch/x86/lib/msr-reg.S > > > @@ -50,7 +50,7 @@ ENDPROC(native_\op\()_safe_regs) > > > > > > #else /* X86_32 */ > > > > > > -.macro op_safe_regs op:req > > > +.macro op_safe_regs op > > > ENTRY(native_\op\()_safe_regs) > > > CFI_STARTPROC > > > pushl_cfi %ebx > > > > > > > > > fixed it. > > > > Yup, already fixed in -tip. > > > > <looks> > > Three days ago. linux-next is still busted. No, the 32-bit ancient-binutils bug you have hit here was found and fixed ~8 hours ago, by me, and i pushed the fix out immediately. (and this happened before you wrote this mail and the fix was posted to lkml as well.) > I want my five minutes back. I too want my five minutes back that i spent researching commit logs and writing this email ;-) Btw., we could save much more if we avoided this whole 'break the kernel then fix it' infinite loop that kernel development is ultimately about ;-) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html