Re: [PATCH 2/3] x86, msr: rewrite AMD rd/wrmsr variants

[Borislav Petkov <petkovbb@xxxxxxxxxxxxxx>]

On Sun, Aug 30, 2009 at 01:03:48PM -0700, H. Peter Anvin wrote:
> On 08/30/2009 04:50 AM, Borislav Petkov wrote:
> > +#define memset(d,c,l) __builtin_memset(d,c,l)
> 
> Uh, *NO*.
> 
> #include <linux/string.h> instead.

With string.h I seem to be getting some symbols visibility conflict at
link time:

arch/x86/boot/compressed/misc.c:134: error: conflicting types for ‘memset’
/home/boris/kernel/linux-2.6/arch/x86/include/asm/msr.h:178: error: previous implicit declaration of ‘memset’ was here
make[2]: *** [arch/x86/boot/compressed/misc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [arch/x86/boot/compressed/vmlinux] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [bzImage] Error 2
make: *** Waiting for unfinished jobs....

Will look more deeply into it tomorrow.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html