Re: [PATCH 3/3] x86, AMD: Disable wrongly set X86_FEATURE_LAHF_LM CPUID bit
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 3/3] x86, AMD: Disable wrongly set X86_FEATURE_LAHF_LM CPUID bit
- From: Borislav Petkov <petkovbb@xxxxxxxxxxxxxx>
- Date: Sun, 30 Aug 2009 21:30:39 +0200
- Cc: mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kjwinchester@xxxxxxxxx, tglx@xxxxxxxxxxxxx, borislav.petkov@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <4A9AD17A.6060507@xxxxxxxxx>
- Mail-followup-to: Borislav Petkov <petkovbb@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, #@liondog.tnic, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kjwinchester@xxxxxxxxx, tglx@xxxxxxxxxxxxx, borislav.petkov@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- References: <1251633031-2244-1-git-send-email-petkovbb@xxxxxxxxx> <1251633031-2244-3-git-send-email-petkovbb@xxxxxxxxx> <4A9AD17A.6060507@xxxxxxxxx>
- User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Aug 30, 2009 at 12:22:34PM -0700, H. Peter Anvin wrote:
> On 08/30/2009 04:50 AM, Borislav Petkov wrote:
> > clear_cpu_cap(c, X86_FEATURE_LAHF_LM);
> > + if (!rdmsrl_amd_safe(0xc001100d, &val)) {
> > + val &= ~(1ULL << 32);
> > + wrmsr_amd_safe(0xc001100d, (u32) val,
> > + (u32)(val >> 32));
> > + }
> > + }
>
> We presumably want/need wrmsrl_amd_safe() here!
Actually, it is wrmsr_amd_safe() because we need the magic value in
%edi. wrmsr_amd_safe() calls the _regs variant with the array argument.
And we don't have a wrmsrl_amd_safe-one which gets a 64bit msr value as
an argument similar to the rdmsrl one.
--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]