Re: [tip:x86/urgent] x86, AMD: Disable wrongly set X86_FEATURE_LAHF_LM CPUID bit
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/urgent] x86, AMD: Disable wrongly set X86_FEATURE_LAHF_LM CPUID bit
- From: Borislav Petkov <petkovbb@xxxxxxxxxxxxxx>
- Date: Sun, 30 Aug 2009 13:43:30 +0200
- Cc: Ingo Molnar <mingo@xxxxxxx>, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kjwinchester@xxxxxxxxx, tglx@xxxxxxxxxxxxx, borislav.petkov@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <4A93884E.3000403@xxxxxxxxx>
- Mail-followup-to: Borislav Petkov <petkovbb@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kjwinchester@xxxxxxxxx, tglx@xxxxxxxxxxxxx, borislav.petkov@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- References: <1250251594-8348-2-git-send-email-borislav.petkov@xxxxxxx> <tip-c74cb13b94118ec89e48849806356b67caa5ff86@xxxxxxxxxxxxxx> <20090816064132.GA16278@xxxxxxx> <20090816214934.GB7765@xxxxxxxxxxxx> <4A8EDC02.8000508@xxxxxxxxx> <20090822163750.GA31631@xxxxxxxxxxxx> <4A92F93F.8000502@xxxxxxxxx> <20090825055215.GA22595@xxxxxxxxxxxx> <4A93884E.3000403@xxxxxxxxx>
- User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Aug 24, 2009 at 11:44:30PM -0700, H. Peter Anvin wrote:
> On 08/24/2009 10:52 PM, Borislav Petkov wrote:
> > On Mon, Aug 24, 2009 at 01:34:07PM -0700, H. Peter Anvin wrote:
> >> Looks reasonable... although part of me wonders if having a pointer to
> >> an array containing the entire register file in and out is even better,
> >> of if I'm just overengineering at this point.
> >
> > Hmm, let's have necessity determine that. I can only think of %edi being
> > used as an input reg to rd/wrmsr beside %ecx but it could be very well
> > that some other x86 hardware uses other regs too. Do we actually need
> > all regs or a two should suffice?
> >
>
> Hard to know. In theory we shouldn't need ESI and EDI either!
>
> As I said, I wouldn't have worried about it at all if it wasn't for
> paravirt_ops turning these things into ABIs.
Ok, here's what I could come up with. It seems to work (tested only on a
Fam10h box), it should cover all our msr needs for now and alleviate the
need for adding yet another paravirt_ops member.
--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]