Re: [tip:tracing/urgent] tracing: Fix too large stack usage in do_one_initcall()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:tracing/urgent] tracing: Fix too large stack usage in do_one_initcall()
- From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- Date: Fri, 21 Aug 2009 12:19:31 -0700 (PDT)
- Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, Arjan van de Ven <arjan@xxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>, Dave Jones <davej@xxxxxxxxxx>, Kyle McMartin <kyle@xxxxxxxxxxx>, Greg KH <gregkh@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, mingo@xxxxxxxxxx, catalin.marinas@xxxxxxx, a.p.zijlstra@xxxxxxxxx, jens.axboe@xxxxxxxxxx, fweisbec@xxxxxxxxx, stable@xxxxxxxxxx, srostedt@xxxxxxxxxx, tglx@xxxxxxxxxxxxx
- In-reply-to: <alpine.LFD.2.01.0908211207410.3158@xxxxxxxxxxxxxxxxxxxxx>
- References: <tip-4a683bf94b8a10e2bb0da07aec3ac0a55e5de61f@xxxxxxxxxxxxxx> <20090821111450.GA32037@xxxxxxx> <20090821104820.60948082.akpm@xxxxxxxxxxxxxxxxxxxx> <alpine.LFD.2.01.0908211108000.3158@xxxxxxxxxxxxxxxxxxxxx> <20090821190226.GA28519@xxxxxxx> <alpine.LFD.2.01.0908211207410.3158@xxxxxxxxxxxxxxxxxxxxx>
- User-agent: Alpine 2.01 (LFD 1184 2008-12-16)
On Fri, 21 Aug 2009, Linus Torvalds wrote:
>
> And we probably should really complain more actively about big stack
> frames. We have that CONFIG_FRAME_WARN thing, but it's set very high.
Hmm. Setting it down to 256 on x86-64 does cause a fair number of
warnings even for something like my personal build (that avoids all the
crazy drivers etc), but it looks "manageable" - ie something where a
kernel developer should try it, and fix all the ones that they maintain.
And if you don't get any warnings in your area, try lowering it to 100 or
something.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]