* tip-bot for Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote: > Commit-ID: 84fce09c6b21ef675de079a724c13a205c89520b > Gitweb: http://git.kernel.org/tip/84fce09c6b21ef675de079a724c13a205c89520b > Author: Frederic Weisbecker <fweisbec@xxxxxxxxx> > AuthorDate: Sat, 8 Aug 2009 02:16:25 +0200 > Committer: Ingo Molnar <mingo@xxxxxxx> > CommitDate: Sat, 8 Aug 2009 13:49:21 +0200 > > perf tools: callchain: Fix sum of percentages to be 100% by displaying amount of ignored chains in fractal mode > > When we filter the callchains below a given percentage, we > ignore them and the end result only shows entries that have an > upper percentage than the filter threshold. > > It seems to users then that we have an imbalance in the > percentage, as if the sum inside a profiled branch doesn't > reach 100%. > > Since in the past there have been real perf report bugs that > showed the same sypmtom, it would be nice to assure the user > that the data is perfect and trustable and it all sums up to > 100.00%. > > So fix this by displaying the remaining hits that have been > filtered but without more detail than their amount in each > branches. Example while filtering below 50%: > > 7.73% [k] delay_tsc > | > |--98.22%-- __const_udelay > | | > | |--86.37%-- ath5k_hw_register_timeout > | | ath5k_hw_noise_floor_calibration > | | ath5k_hw_reset > | | ath5k_reset > | | ath5k_config > | | ieee80211_hw_config > | | | > | | |--88.53%-- ieee80211_scan_work > | | | worker_thread > | | | kthread > | | | child_rip > | | --11.47%-- [...] > | --13.63%-- [...] > --1.78%-- [...] i dont seem to be able to get the bracketed numbers. I only get: titan:~> perf record -f -g -a ./hackbench 10 titan:~> perf report -g fractal,10.0 # Samples: 26832 # # Overhead Command Shared Object Symbol # ........ .............. ........................ ...... # 8.69% hackbench [kernel] [k] copy_user_generic_string 6.84% hackbench [kernel] [k] unix_stream_recvmsg 6.07% hackbench [kernel] [k] sock_alloc_send_pskb 4.33% hackbench [kernel] [k] _spin_lock 3.77% hackbench [kernel] [k] __kmalloc_node_track_caller 3.74% hackbench [kernel] [k] __alloc_skb | |--80.00%-- sock_alloc_send_pskb | sock_alloc_send_skb | unix_stream_sendmsg | __sock_sendmsg | sock_aio_write | do_sync_write | vfs_write | sys_write | sysenter_dispatch | 0xf7ffa430 | 0xffadeb0000000014 | --20.00%-- sock_alloc_send_skb unix_stream_sendmsg __sock_sendmsg sock_aio_write do_sync_write vfs_write sys_write sysenter_dispatch 0xf7ffa430 0xffadeb0000000014 3.53% hackbench [kernel] [k] ia32_sysenter_target 2.92% hackbench [vdso] [.] 0x000000f7ffa430 | |--66.67%-- 0xf7ffa430 | 0xffadeb0000000014 | --33.33%-- 0xf7ffa431 0xffadeb0000000014 2.56% hackbench [kernel] [k] virt_to_head_page 2.37% hackbench [kernel] [k] kmem_cache_alloc_node 2.33% hackbench [kernel] [k] _spin_lock_irqsave | |--78.57%-- remove_wait_queue | poll_freewait | do_sys_poll | sys_poll | sysenter_dispatch | 0xf7ffa430 | 0x1ffadea3c | |--7.14%-- __up_read | up_read | do_page_fault | page_fault | 0xf7ffa430 | 0xa0df710000000a | |--7.14%-- unix_stream_sendmsg | __sock_sendmsg | sock_aio_write | do_sync_write | vfs_write | sys_write | sysenter_dispatch | 0xf7ffa430 | 0xffadeb0000000014 | --7.14%-- skb_queue_tail unix_stream_sendmsg __sock_sendmsg sock_aio_write do_sync_write vfs_write sys_write sysenter_dispatch 0xf7ffa430 0xffadeb0000000014 I dont see the brackets anymore, nor does the 10% limit seem to have been listened to for the 7.14% result above, right? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html