[tip:x86/urgent] x86: comment formatting cleanup in arch/x86/kernel/tsc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit-ID:  1fddf9f09de9ee586ee6924a094a1660389369d1
Gitweb:     http://git.kernel.org/tip/1fddf9f09de9ee586ee6924a094a1660389369d1
Author:     H. Peter Anvin <hpa@xxxxxxxxx>
AuthorDate: Fri, 31 Jul 2009 10:43:42 -0700
Committer:  H. Peter Anvin <hpa@xxxxxxxxx>
CommitDate: Fri, 31 Jul 2009 10:48:23 -0700

x86: comment formatting cleanup in arch/x86/kernel/tsc.c

Clean up the style of a newly added comment
(checkin fb34a8ee86cb52ee688627f820ed6c80ee033219).

Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx>
Cc: Wei Chong Tan <wei.chong.tan@xxxxxxxxx>


---
 arch/x86/kernel/tsc.c |   29 ++++++++++++++++-------------
 1 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 68e93c1..261ff00 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -285,25 +285,28 @@ static inline int pit_expect_msb(unsigned char val, u64 *tscp, unsigned long *de
 		inb(0x42);
 		if (inb(0x42) != val)
 			break;
-		/* What if an SMI kicks in here when
-		 * count is just slightly over 5 and SMI run long enough
-		 * so that PIT MSB value is way bigger then val?
-		 * Then tscp will have an unreasonably large value,
-		 * since the code has no notion of
-		 * how much inb(0x42) MSB is bigger then val when it return from SMI.
+		/* 
+		 * What if an SMI kicks in here when count is just
+		 * slightly over 5 and SMI run long enough so that PIT
+		 * MSB value is way bigger then val?  Then tscp will
+		 * have an unreasonably large value, since the code
+		 * has no notion of how much inb(0x42) MSB is bigger
+		 * then val when it return from SMI.
+		 *
 		 * In addition, since the 2 get_cycles() are near,
-		 * deltap may get a sane value.
-		 * If this happen on the final few readings
-		 * just before (d1+d2 < delta >> 11),
-		 * this may skew the average delta variable of quick_pit_calibrate().
+		 * deltap may get a sane value.  If this happen on the
+		 * final few readings just before
+		 * (d1+d2 < delta >> * 11), this may skew the average
+		 * delta variable of quick_pit_calibrate().
 		 */
 		tsc = get_cycles();
 	}
 	*deltap = get_cycles() - tsc;
 	*tscp = tsc;
-	/* inb(0x42) will need to be separately repeated here as
-	 * the SMI may take so long that the old reading
-	 * is no longer reliable. inb(0x42) after all get_cycles is the safest.
+	/*
+	 * inb(0x42) will need to be separately repeated here as the
+	 * SMI may take so long that the old reading is no longer
+	 * reliable. inb(0x42) after all get_cycles is the safest.
 	 */
 	inb(0x42);
 	if (inb(0x42) < (val - 1))
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux