Commit-ID: d07387b490b1c43bfcb9f3900faf96f2dafb2630 Gitweb: http://git.kernel.org/tip/d07387b490b1c43bfcb9f3900faf96f2dafb2630 Author: Paul Turner <pjt@xxxxxxxxxx> AuthorDate: Fri, 10 Jul 2009 17:05:16 -0700 Committer: Ingo Molnar <mingo@xxxxxxx> CommitDate: Sat, 11 Jul 2009 10:00:09 +0200 sched: Fix bug in SCHED_IDLE interaction with group scheduling One of the isolation modifications for SCHED_IDLE is the unitization of sleeper credit. However the check for this assumes that the sched_entity we're placing always belongs to a task. This is potentially not true with group scheduling and leaves us rummaging randomly when we try to pull the policy. Signed-off-by: Paul Turner <pjt@xxxxxxxxxx> Cc: peterz@xxxxxxxxxxxxx LKML-Reference: <alpine.DEB.1.00.0907101649570.29914@xxxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Ingo Molnar <mingo@xxxxxxx> --- kernel/sched_fair.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index ba7fd6e..7c248dc 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -687,7 +687,8 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int initial) * all of which have the same weight. */ if (sched_feat(NORMALIZED_SLEEPER) && - task_of(se)->policy != SCHED_IDLE) + (!entity_is_task(se) || + task_of(se)->policy != SCHED_IDLE)) thresh = calc_delta_fair(thresh, se); vruntime -= thresh; -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|