Re: [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit atomic64_t implementation to a .c file
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit atomic64_t implementation to a .c file
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Sun, 5 Jul 2009 13:25:45 +0200
- Cc: mingo@xxxxxxxxxx, hpa@xxxxxxxxx, acme@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, eric.dumazet@xxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, a.p.zijlstra@xxxxxxxxx, efault@xxxxxx, arnd@xxxxxxxx, fweisbec@xxxxxxxxx, dhowells@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <19022.40132.606734.933933@xxxxxxxxxxxxxxxxxxxx>
- References: <alpine.LFD.2.01.0907021653030.3210@xxxxxxxxxxxxxxxxxxxxx> <tip-b7882b7c65abb00194bdb3d4a22d27d70fcc59ba@xxxxxxxxxxxxxx> <19022.40132.606734.933933@xxxxxxxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.18 (2008-05-17)
* Paul Mackerras <paulus@xxxxxxxxx> wrote:
> tip-bot for Ingo Molnar writes:
>
> > Also, while at it, rename all uses of 'unsigned long long' to
> > the much shorter u64.
> >
> > This makes the appearance of the prototypes a lot nicer - and
> > it also uncovered a few bugs where (yet unused) API variants
> > had 'long' as their return type instead of u64.
>
> Did you consider making atomic64_t a signed type on 32-bit x86
> like it is on all 64-bit platforms, and like atomic_t is
> everywhere?
That did not occur to me and it makes sense - this would clean up a
few explicit s64 casts we do there currently.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]
