On Wed, 2009-07-01 at 14:06 +0000, tip-bot for Xiao Guangrong wrote: > Commit-ID: 5c37f525657e879a17a27c83021602cd55837531 > Gitweb: http://git.kernel.org/tip/5c37f525657e879a17a27c83021602cd55837531 > Author: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx> > AuthorDate: Wed, 1 Jul 2009 16:50:25 +0800 > Committer: Ingo Molnar <mingo@xxxxxxx> > CommitDate: Wed, 1 Jul 2009 16:03:50 +0200 > > tracing: Fix trace_print_seq() > > We will lose something if trace_seq->buffer[0] is 0, because the copy length > is calculated by strlen() in seq_puts(), so using seq_write() instead of > seq_puts(). > > There have a example: > after reboot: > > # echo kmemtrace > current_tracer > # echo 0 > options/kmem_minimalistic > # cat trace > # tracer: kmemtrace > # > # > > Nothing is exported, because the first byte of trace_seq->buffer[ ] > is KMEMTRACE_USER_ALLOC. > > ( the value of KMEMTRACE_USER_ALLOC is zero, seeing > kmemtrace_print_alloc_user() in kernel/trace/kmemtrace.c) > > Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx> > Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx> > Cc: Eduard - Gabriel Munteanu <eduard.munteanu@xxxxxxxxxxx> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Cc: Pekka Enberg <penberg@xxxxxxxxxxxxxx> > LKML-Reference: <4A4B2351.5010300@xxxxxxxxxxxxxx> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx> Nice catch! Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|