Re: [tip:perfcounters/core] perf_counter: x86: Fix call-chain support to use NMI-safe methods
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:perfcounters/core] perf_counter: x86: Fix call-chain support to use NMI-safe methods
- From: "H. Peter Anvin" <hpa@xxxxxxxxx>
- Date: Mon, 15 Jun 2009 13:10:44 -0700
- Cc: Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, mingo@xxxxxxxxxx, paulus@xxxxxxxxx, acme@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, a.p.zijlstra@xxxxxxxxx, penberg@xxxxxxxxxxxxxx, vegard.nossum@xxxxxxxxx, efault@xxxxxx, jeremy@xxxxxxxx, npiggin@xxxxxxx, tglx@xxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20090615200619.GA10632@Krystal>
- References: <tip-74193ef0ecab92535c8517f082f1f50504526c9b@xxxxxxxxxxxxxx> <alpine.LFD.2.01.0906151007560.3305@xxxxxxxxxxxxxxxxxxxxx> <20090615171845.GA7664@xxxxxxx> <alpine.LFD.2.01.0906151029160.3305@xxxxxxxxxxxxxxxxxxxxx> <20090615180527.GB4201@Krystal> <alpine.LFD.2.01.0906151125320.6276@xxxxxxxxxxxxxxxxxxxxx> <20090615183649.GA16999@xxxxxxx> <alpine.LFD.2.01.0906151152170.6276@xxxxxxxxxxxxxxxxxxxxx> <20090615194344.GA12554@xxxxxxx> <20090615200619.GA10632@Krystal>
- User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Mathieu Desnoyers wrote:
>
> In the category "crazy ideas one should never express out loud", I could add the
> following. We could choose to save/restore the cr2 register on the local stack
> at every interrupt entry/exit, and therefore allow the page fault handler to
> execute with interrupts enabled.
>
> I have not benchmarked the interrupt disabling overhead of the page fault
> handler handled by starting an interrupt-gated handler rather than trap-gated
> handler, but cli/sti instructions are known to take quite a few cycles on some
> architectures. e.g. 131 cycles for the pair on P4, 23 cycles on AMD Athlon X2
> 64, 43 cycles on Intel Core2.
>
> I am tempted to think that taking, say, ~10 cycles on the interrupt path worths
> it if we save a few tens of cycles on the page fault handler fast path.
>
Doesn't sound all that crazy, I suspect the underlying assumption that
interrupt gates are slower than trap gates is incorrect. Disabling
interrupts itself isn't expensive, it's the synchronization requirements.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]