Commit-ID: c3f10fbccdb558dbc0652487502bbd7150231945
Gitweb: http://git.kernel.org/tip/c3f10fbccdb558dbc0652487502bbd7150231945
Author: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
AuthorDate: Fri, 8 May 2009 16:52:07 +0100
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Mon, 11 May 2009 17:03:02 +0200
x86: use flush_tlb_others to implement flush_tlb_all, fix
"use the flush_tlb_others() call to implement flush_tlb_all()"
causes:
BUG: spinlock bad magic on CPU#0, swapper/0
lock: c05b7588, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
Pid: 0, comm: swapper Not tainted 2.6.30-rc3-x86_32p-xen0-tip-01797-g3db7847 #1054
Call Trace:
[<c023e656>] spin_bug+0x96/0xf0
[<c023e90f>] _raw_spin_lock+0x6f/0x150
It can be called before the core_initcalls are run. Explicitly call
init_smp_flush early on.
Also there is no need for init_smp_flush to be __cpuinit.
[ Impact: fix boot crash/warning ]
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Acked-by: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>
LKML-Reference: <1241797927.15972.51.camel@xxxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
arch/x86/include/asm/tlbflush.h | 2 ++
arch/x86/kernel/setup.c | 2 ++
arch/x86/mm/tlb.c | 3 +--
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index 16a5c84..2a4848d 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/include/asm/tlbflush.h
@@ -129,6 +129,8 @@ static inline void reset_lazy_tlbstate(void)
#define local_flush_tlb() __flush_tlb()
+extern int init_smp_flush(void);
+
extern void flush_tlb_all(void);
extern void flush_tlb_current_task(void);
extern void flush_tlb_mm(struct mm_struct *);
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index b415843..bde4baf 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -984,6 +984,8 @@ void __init setup_arch(char **cmdline_p)
e820_setup_gap();
+ init_smp_flush();
+
#ifdef CONFIG_VT
#if defined(CONFIG_VGA_CONSOLE)
if (!efi_enabled || (efi_mem_type(0xa0000) != EFI_CONVENTIONAL_MEMORY))
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index e69bdad..0f030fb 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -229,7 +229,7 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
flush_tlb_others_ipi(cpumask, mm, va);
}
-static int __cpuinit init_smp_flush(void)
+int __init init_smp_flush(void)
{
int i;
@@ -238,7 +238,6 @@ static int __cpuinit init_smp_flush(void)
return 0;
}
-core_initcall(init_smp_flush);
void flush_tlb_current_task(void)
{
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|