* tip-bot for Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> wrote: > Commit-ID: 636afdbe85d50d9b88f5283b5e6d0f8518431aac > Gitweb: http://git.kernel.org/tip/636afdbe85d50d9b88f5283b5e6d0f8518431aac > Author: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> > AuthorDate: Fri, 8 May 2009 16:52:07 +0100 > Committer: Ingo Molnar <mingo@xxxxxxx> > CommitDate: Mon, 11 May 2009 15:08:08 +0200 > > x86: use flush_tlb_others to implement flush_tlb_all, fix > > "use the flush_tlb_others() call to implement flush_tlb_all()" > causes: > BUG: spinlock bad magic on CPU#0, swapper/0 > lock: c05b7588, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 > Pid: 0, comm: swapper Not tainted 2.6.30-rc3-x86_32p-xen0-tip-01797-g3db7847 #1054 > Call Trace: > [<c023e656>] spin_bug+0x96/0xf0 > [<c023e90f>] _raw_spin_lock+0x6f/0x150 > > It can be called before the core_initcalls are run. Explicitly call > init_smp_flush early on. > > Also there is no need for init_smp_flush to be __cpuinit. > > [ Impact: fix boot crash/warning ] > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> > Acked-by: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx> > LKML-Reference: <1241797927.15972.51.camel@xxxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx> > > > --- > arch/x86/include/asm/tlbflush.h | 2 ++ > arch/x86/mm/tlb.c | 3 +-- > init/main.c | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) which then does: init/main.c:728: error: implicit declaration of function ‘init_smp_flush’ i've excluded tip:x86/xen from tip:master for now. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|