Commit-ID: 84f201139245c30777ff858e71b8d7e134b8c3ed Gitweb: http://git.kernel.org/tip/84f201139245c30777ff858e71b8d7e134b8c3ed Author: Markus Metzger <markus.t.metzger@xxxxxxxxx> AuthorDate: Fri, 3 Apr 2009 16:43:43 +0200 Committer: Ingo Molnar <mingo@xxxxxxx> CommitDate: Tue, 7 Apr 2009 13:36:24 +0200 x86, ds: fix bounds check in ds selftest Fix a bad bounds check in the debug store selftest. Signed-off-by: Markus Metzger <markus.t.metzger@xxxxxxxxx> Cc: roland@xxxxxxxxxx Cc: eranian@xxxxxxxxxxxxxx Cc: oleg@xxxxxxxxxx Cc: juan.villacis@xxxxxxxxx Cc: ak@xxxxxxxxxxxxxxxxxx LKML-Reference: <20090403144558.450027000@xxxxxxxxx> Signed-off-by: Ingo Molnar <mingo@xxxxxxx> --- arch/x86/kernel/ds_selftest.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/ds_selftest.c b/arch/x86/kernel/ds_selftest.c index e1ba510..cccc19a 100644 --- a/arch/x86/kernel/ds_selftest.c +++ b/arch/x86/kernel/ds_selftest.c @@ -47,8 +47,13 @@ static int ds_selftest_bts_consistency(const struct bts_trace *trace) printk(KERN_CONT "bad bts buffer setup..."); error = -1; } + /* + * We allow top in [begin; end], since its not clear when the + * overflow adjustment happens: after the increment or before the + * write. + */ if ((trace->ds.top < trace->ds.begin) || - (trace->ds.end <= trace->ds.top)) { + (trace->ds.end < trace->ds.top)) { printk(KERN_CONT "bts top out of bounds..."); error = -1; } -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html