[tip-bot for Suresh Siddha - Tue, Apr 21, 2009 at 08:07:00AM +0000]
| Commit-ID: 25629d810a52176758401184d9b437fbb7f79195
| Gitweb: http://git.kernel.org/tip/25629d810a52176758401184d9b437fbb7f79195
| Author: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
| AuthorDate: Mon, 20 Apr 2009 13:02:28 -0700
| Committer: Ingo Molnar <mingo@xxxxxxx>
| CommitDate: Tue, 21 Apr 2009 09:08:26 +0200
|
| x86: x2apic, IR: Move eoi_ioapic_irq() into a CONFIG_INTR_REMAP section
|
| Address the following complier warning:
|
| arch/x86/kernel/apic/io_apic.c:2543: warning: `eoi_ioapic_irq' defined but not used
|
| By moving that function (and eoi_ioapic_irq()) into an existing
| #ifdef CONFIG_INTR_REMAP section of the code.
|
| [ Impact: cleanup ]
|
| Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
| Cc: dwmw2@xxxxxxxxxxxxx
| Cc: Weidong Han <weidong.han@xxxxxxxxx>
| LKML-Reference: <20090420200450.271099000@xxxxxxxxxxxxxxxxxxxxx>
| Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
| Cc: Weidong Han <weidong.han@xxxxxxxxx>
|
|
| ---
| arch/x86/kernel/apic/io_apic.c | 66 ++++++++++++++++++++--------------------
| 1 files changed, 33 insertions(+), 33 deletions(-)
|
...
| #ifdef CONFIG_INTR_REMAP
| +static void __eoi_ioapic_irq(unsigned int irq, struct irq_cfg *cfg)
| +{
| + int apic, pin;
| + struct irq_pin_list *entry;
| +
| + entry = cfg->irq_2_pin;
| + for (;;) {
| +
| + if (!entry)
| + break;
| +
| + apic = entry->apic;
| + pin = entry->pin;
| + io_apic_eoi(apic, pin);
| + entry = entry->next;
| + }
| +}
| +
...
Btw, maybe we better could use plain "while(entry) {...}" here?
Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|