* Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote: > Ingo Molnar wrote: > > * Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote: > > > >> tip-bot for Rakib Mullick pisze: > >>> Commit-ID: aa57a15ad17d284e62fbd24cf7e0eb628b2cb3f7 > >>> Gitweb: http://git.kernel.org/tip/aa57a15ad17d284e62fbd24cf7e0eb628b2cb3f7 > >>> Author: Rakib Mullick <rakib.mullick@xxxxxxxxx> > >>> AuthorDate: Sun, 19 Apr 2009 08:41:17 +0600 > >>> Committer: Ingo Molnar <mingo@xxxxxxx> > >>> CommitDate: Sun, 19 Apr 2009 11:28:18 +0200 > >>> > >>> x86: Fix false positive section mismatch warnings in the apic code > >>> > >>> find_unisys_acpi_oem_table() and unmap_unisys_acpi_oem_table() > >>> are non init functions, but these functions calls some init > >>> functions. But we need these functions as non-init functions. > >> Why? This warning seems to be valid. > > > > It's put into struct apic::acpi_madt_oem_check - which is a > > non-init structure. That particular field is only used from init > > context - but other fields are used all the time. > > Can we have a rule that "every __ref usage should have a comment > explaining why __ref is safe in this place"? Yes, that's prudent. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|