On Thu, 2009-04-02 at 17:21 +0200, Thomas Gleixner wrote:
> On Thu, 2 Apr 2009, Jaswinder Singh Rajput wrote:
> > On Thu, 2009-04-02 at 14:03 +0000, Luis Henriques wrote:
> > > Commit-ID: ba71604fad348656071a2a76eef9a67dab85a773
> > > Gitweb: http://git.kernel.org/tip/ba71604fad348656071a2a76eef9a67dab85a773
> > > Author: Luis Henriques <henrix@xxxxxxx>
> > > AuthorDate: Wed, 1 Apr 2009 18:06:35 +0100
> > > Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > > CommitDate: Thu, 2 Apr 2009 16:02:39 +0200
> > >
> > > genirq: do not execute DEBUG_SHIRQ when irq setup failed
> > >
> > > When requesting an IRQ, the DEBUG_SHIRQ code executes a fake IRQ just to make
> > > sure the driver is ready to receive an IRQ immediately. The problem was that
> > > this fake IRQ was being executed even if interrupt line failed to be allocated
> > > by __setup_irq.
> > >
> > > Signed-off-by: Luis Henriques <henrix@xxxxxxx>
> > > LKML-Reference: <20090401170635.GA4392@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > >
> > >
> > > ---
> > > kernel/irq/manage.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> > > index 1516ab7..beeb7d1 100644
> > > --- a/kernel/irq/manage.c
> > > +++ b/kernel/irq/manage.c
> > > @@ -768,7 +768,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
> > > kfree(action);
> > >
> > > #ifdef CONFIG_DEBUG_SHIRQ
> > > - if (irqflags & IRQF_SHARED) {
> > > + if (!retval & (irqflags & IRQF_SHARED)) {
> > > /*
> > > * It's a shared IRQ -- the driver ought to be prepared for it
> > > * to happen immediately, so let's make sure....
> >
> > What is this ?
>
> You looking at the wrong place.
>
> > There is no retval:
> >
> > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=blob;f=kernel/irq/manage.c;h=a3eb7baf1e46f2c735edb4cc44e0386cfbc4989e;hb=HEAD
>
> Care to read patches you want to comment on carefully _BEFORE_ you
> start yelling at people and sending useless copies of the wrong
> function around the world.
>
> The patch is perfectly fine and already applied.
>
Yes, I know somehow you applied it. When you will merge this branch with
-tip/master then you will understand what I am saying.
Even function name is changed from:
713 int request_irq(unsigned int irq, irq_handler_t handler,
714
unsigned long irqflags, const char *devname, void *dev_id)
715 {
716 struct irqaction *action;
717 struct irq_desc *desc;
718 int retval;
to:
857 int request_threaded_irq(unsigned int irq, irq_handler_t handler,
858
irq_handler_t thread_fn, unsigned long irqflags,
859 const char *devname, void *dev_id)
860 {
861 struct irqaction *action;
862 struct irq_desc *desc;
863 int retval;
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|