Commit-ID: eb12ce60c81826a99eadbc56401e08ceb37a0cc2 Gitweb: http://git.kernel.org/tip/eb12ce60c81826a99eadbc56401e08ceb37a0cc2 Author: Tejun Heo <tj@xxxxxxxxxx> AuthorDate: Wed, 1 Apr 2009 15:06:33 +0900 Committer: Ingo Molnar <mingo@xxxxxxx> CommitDate: Thu, 2 Apr 2009 06:08:05 +0200 x86,percpu: fix inverted NUMA test in setup_pcpu_remap() setup_percpu_remap() is for NUMA machines yet it bailed out with -EINVAL if pcpu_need_numa(). Fix the inverted condition. This problem was reported by David Miller and verified by Yinhai Lu. Reported-by: David Miller <davem@xxxxxxxxxxxxx> Reported-by: Yinghai Lu <yinghai@xxxxxxxxxx> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> LKML-Reference: <49D30469.8020006@xxxxxxxxxx> Signed-off-by: Ingo Molnar <mingo@xxxxxxx> --- arch/x86/kernel/setup_percpu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c index 400331b..876b127 100644 --- a/arch/x86/kernel/setup_percpu.c +++ b/arch/x86/kernel/setup_percpu.c @@ -162,7 +162,7 @@ static ssize_t __init setup_pcpu_remap(size_t static_size) * If large page isn't supported, there's no benefit in doing * this. Also, on non-NUMA, embedding is better. */ - if (!cpu_has_pse || pcpu_need_numa()) + if (!cpu_has_pse || !pcpu_need_numa()) return -EINVAL; last = NULL; -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html