* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > On Fri, 2009-03-13 at 01:39 +0000, Jan Beulich wrote: > > Commit-ID: 6a09dfa870ba0ed21b1124539968a36b42660661 > > Gitweb: http://git.kernel.org/tip/6a09dfa870ba0ed21b1124539968a36b42660661 > > Author: Jan Beulich <jbeulich@xxxxxxxxxx> > > AuthorDate: Thu, 12 Mar 2009 13:21:50 +0000 > > Commit: Ingo Molnar <mingo@xxxxxxx> > > CommitDate: Fri, 13 Mar 2009 02:14:41 +0100 > > > > generic-ipi: eliminate spurious pointless WARN_ON()s > > > > Namely during early boot, the panic() or BUG() paths may end up in > > smp_call_function_*() with just a single online CPU. In that situation > > the warnings generated are not only meaningless, but also result in > > relevant output being cluttered. > > > > Therefore, defer the WARN_ON() checks until after the (unaffected from > > the problem that is being attempted to be detected here) cases have > > been handled. > > > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> > > LKML-Reference: <49B91A7E.76E4.0078.0@xxxxxxxxxx> > > Signed-off-by: Ingo Molnar <mingo@xxxxxxx> > > I don't really like this,.. it moves the WARN_ON to weird > locations without an explanatory comment. ok, i've reverted it for now. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|