Peter Zijlstra wrote: > On Sun, 2009-03-08 at 15:52 +0000, Jaswinder Singh Rajput wrote: >> Commit-ID: e255357764f92afcafafbd4879b222b8c752065a >> Gitweb: http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a >> Author: "Jaswinder Singh Rajput" <jaswinder@xxxxxxxxxx> >> AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530 >> Commit: Ingo Molnar <mingo@xxxxxxx> >> CommitDate: Sun, 8 Mar 2009 16:26:50 +0100 >> >> x86: perf_counter cleanup >> >> Remove unused variables and duplicate header file. > > Why did you commit this? > > Until someone from AMD steps up and either tells us they're going to be > 48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd > rather try and get the dynamic thing working. > That would be good, but there really is absolutely no reason to leave in variables which are unused in the current code and therefore give a gcc warning. It's not like adding new declaration is hard. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html