Commit-ID: 86028598de16538f02519141756ccf4accfc29a6 Gitweb: http://git.kernel.org/tip/86028598de16538f02519141756ccf4accfc29a6 Author: "Paul Mackerras" <paulus@xxxxxxxxx> AuthorDate: Thu, 5 Mar 2009 14:05:57 +1100 Commit: Paul Mackerras <paulus@xxxxxxxxx> CommitDate: Fri, 6 Mar 2009 08:07:13 +1100 perfcounters/powerpc: fix oops with multiple counters in a group Impact: fix oops-causing bug This fixes a bug in the powerpc hw_perf_counter_init where the code didn't initialize ctrs[n] before passing the ctrs array to check_excludes, leading to possible oopses and other incorrect behaviour. This fixes it by initializing ctrs[n] correctly. Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx> --- arch/powerpc/kernel/perf_counter.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/kernel/perf_counter.c b/arch/powerpc/kernel/perf_counter.c index 112332d..4fec112 100644 --- a/arch/powerpc/kernel/perf_counter.c +++ b/arch/powerpc/kernel/perf_counter.c @@ -633,6 +633,7 @@ hw_perf_counter_init(struct perf_counter *counter) return NULL; } events[n] = ev; + ctrs[n] = counter; if (check_excludes(ctrs, n, 1)) return NULL; if (power_check_constraints(events, n + 1)) -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|