[tip:kmemcheck] kmemcheck: use kmemcheck_pte_lookup() instead of open-coding it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Author:     Pekka Enberg <penberg@xxxxxxxxxxxxxx>
AuthorDate: Thu, 26 Feb 2009 11:53:11 +0200
Commit:     Vegard Nossum <vegard.nossum@xxxxxxxxx>
CommitDate: Thu, 26 Feb 2009 14:09:22 +0100

kmemcheck: use kmemcheck_pte_lookup() instead of open-coding it

Impact: cleanup

Lets use kmemcheck_pte_lookup() in kmemcheck_fault() instead of
open-coding it there.

Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
Signed-off-by: Vegard Nossum <vegard.nossum@xxxxxxxxx>


---
 arch/x86/mm/kmemcheck/kmemcheck.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/arch/x86/mm/kmemcheck/kmemcheck.c b/arch/x86/mm/kmemcheck/kmemcheck.c
index 704fb62..9349565 100644
--- a/arch/x86/mm/kmemcheck/kmemcheck.c
+++ b/arch/x86/mm/kmemcheck/kmemcheck.c
@@ -593,7 +593,6 @@ bool kmemcheck_fault(struct pt_regs *regs, unsigned long address,
 	unsigned long error_code)
 {
 	pte_t *pte;
-	unsigned int level;
 
 	/*
 	 * XXX: Is it safe to assume that memory accesses from virtual 86
@@ -606,13 +605,9 @@ bool kmemcheck_fault(struct pt_regs *regs, unsigned long address,
 	if (regs->cs != __KERNEL_CS)
 		return false;
 
-	pte = lookup_address(address, &level);
+	pte = kmemcheck_pte_lookup(address);
 	if (!pte)
 		return false;
-	if (level != PG_LEVEL_4K)
-		return false;
-	if (!pte_hidden(*pte))
-		return false;
 
 	if (error_code & 2)
 		kmemcheck_access(regs, address, KMEMCHECK_WRITE);
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux