Hi Ingo, Ingo Molnar wrote: > another very small thing, while we are discussing kprobes: > > I always found that the __kprobes annotation is very confusingly > euphemistic: what those annotations really mean is not > 'kprobes', but 'no kprobes'. As far as I know, __kprobes originally means 'this function will be called from kprobes'. However, now many functions are tagged as __kprobes, it might be confusingly. > So how about renaming __kprobes to __nokprobes, similar to how > we have the notrace attribute? Would you mean that will include changing section name of '.text.kprobes'? That's what I mind. > We have about 350 __kprobes annotations in the kernel, so > renaming it now would not be practical - but any objections > against me sending Linus a rename patch somewhere late in the > next merge window that just does this rename? Just renaming __kprobes to __nokprobes seems good for me. Thank you! > [ likewise, i'll rename notrace to __notrace to make it visually > less intrusive to the return value type. There's a lot less > such annotations in the kernel. ] > > Ingo > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|