I maintain several hosts with tegra210-quad controllers, some of which
experience data transmission failures. Debugging these issues has been
challenging due to excessive log messages from the driver.
All my tegra210-quad systems report "device reset failed" at boot and
during recovery attempts. Upon investigation, I found this message is
misleading - the driver isn't failing to reset the device, but rather
device_reset() returns non-zero because no _RST ACPI method exists. The
first patch replaces this with device_reset_optional(), which doesn't
return negative values when ACPI handlers are absent.
Additionally, when transmission failures occur, the kernel logs become
flooded with repetitive warnings and error messages from tegra210-quad,
making them nearly unreadable. The second and third patches in this
series address this by:
1. Using WARN_ON_ONCE instead of WARN_ON to reduce stack trace spam
2. Rate-limiting error messages and removing redundant information
These improvements maintain necessary error reporting while significantly
reducing log noise, making debugging of actual issues more feasible.
Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
---
Breno Leitao (3):
spi: tegra210-quad: use device_reset_optional() instead of device_reset()
spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
spi: tegra210-quad: add rate limiting and simplify timeout error message
drivers/spi/spi-tegra210-quad.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
---
base-commit: 4701f33a10702d5fc577c32434eb62adde0a1ae1
change-id: 20250317-tegra-1712e60604e6
Best regards,
--
Breno Leitao <leitao@xxxxxxxxxx>
