On Tue, Feb 18, 2025 at 8:28 PM Haoxiang Li <haoxiang_li2024@xxxxxxx> wrote:
>
> Add check for the return value of devm_kstrdup_const() in
> tegra_hsp_doorbell_create() to catch potential exception.
>
> Fixes: a54d03ed01b4 ("mailbox: tegra-hsp: use devm_kstrdup_const()")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
> drivers/mailbox/tegra-hsp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
> index c1981f091bd1..773a1cf6d93d 100644
> --- a/drivers/mailbox/tegra-hsp.c
> +++ b/drivers/mailbox/tegra-hsp.c
> @@ -285,6 +285,8 @@ tegra_hsp_doorbell_create(struct tegra_hsp *hsp, const char *name,
> db->channel.hsp = hsp;
>
> db->name = devm_kstrdup_const(hsp->dev, name, GFP_KERNEL);
> + if (!db->name)
> + return ERR_PTR(-ENOMEM);
tegra_hsp_doorbell.name seems unused, so maybe just get rid of it... Thierry ?
Thnx
