On Fri, Feb 14, 2025 at 08:21:03AM +0200, Svyatoslav Ryhel wrote: > чт, 13 лют. 2025 р. о 22:15 Conor Dooley <conor@xxxxxxxxxx> пише: > > > > On Wed, Feb 12, 2025 at 09:39:06PM +0200, Svyatoslav Ryhel wrote: > > > ср, 12 лют. 2025 р. о 21:20 Conor Dooley <conor@xxxxxxxxxx> пише: > > > > > > > > On Wed, Feb 12, 2025 at 08:46:55AM +0200, Svyatoslav Ryhel wrote: > > > > > AL3000a is an ambient light sensor quite closely related to > > > > > exising AL3010 and can re-use exising schema for AL3010. > > > > > > > > Quite close you say, but the driver is entirely different it seems. How > > > > closely related is the hardware itself? > > > > > > > > > > Well, I can simply duplicate al3010 or al3320a schema if re-using > > > schema is not allowed. AL3000a has no available datasheet online. > > > Downstream code for al3000a and al3010 seems to have same principles, > > > apart from light measurements. > > > > It's probably more of a question as to why you're duplicating the driver > > for them, rather than telling you not to put both bindings together. > > That said, information on what's actually different is helpful in the > > binding, to explain why you're not using a fallback compatible etc. > > > > Quoting writing-bindings.rst: > DON'T refer to Linux or "device driver" in bindings. Bindings should > be based on what the hardware has, not what an OS and driver currently > support. No need to quite that back at me, I'm the one usually attempting to enforce these things. I just expect more information about the similiarties/differences when you're content splitting into two drivers but want to reuse the same binding. > > From all available data, hw configuration of al3000a closely matches > al3010 and seems to be part of same sensor lineup. It is not > prohibited to add new compatibles to existing schema. Schema does not > take in account way of processing data generated by sensor and this is > the main difference between al3000a and al3010 Please mention this in your commit message. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
