On 05-02-2025 19:45, Thierry Reding wrote:
On Mon, Feb 03, 2025 at 10:53:04AM +0000, Sheetal . wrote:
From: Sheetal <sheetal@xxxxxxxxxx>
Add interconnect framework support to set required audio bandwidth
based on PCM device usage. The maximum bandwidth is determined by
the number of APE PCM devices and maximum audio format supported.
If interconnect property is not defined or INTERCONNECT config
is not enabled then the audio usecase will still function.
Validate bandwidth updates by reading the interconnect summary sysfs
node during PCM device open and close operations.
Signed-off-by: Sheetal <sheetal@xxxxxxxxxx>
---
v2: Fix pcm_id parameter uninitialized warning.
---
sound/soc/tegra/Makefile | 2 +-
sound/soc/tegra/tegra210_admaif.c | 24 +++++-
sound/soc/tegra/tegra210_admaif.h | 9 +-
sound/soc/tegra/tegra_isomgr_bw.c | 132 ++++++++++++++++++++++++++++++
sound/soc/tegra/tegra_isomgr_bw.h | 31 +++++++
5 files changed, 192 insertions(+), 6 deletions(-)
create mode 100644 sound/soc/tegra/tegra_isomgr_bw.c
create mode 100644 sound/soc/tegra/tegra_isomgr_bw.h
diff --git a/sound/soc/tegra/Makefile b/sound/soc/tegra/Makefile
index cea4b0d54378..defea7f53f11 100644
--- a/sound/soc/tegra/Makefile
+++ b/sound/soc/tegra/Makefile
@@ -13,7 +13,7 @@ snd-soc-tegra210-dmic-y := tegra210_dmic.o
snd-soc-tegra210-i2s-y := tegra210_i2s.o
snd-soc-tegra186-asrc-y := tegra186_asrc.o
snd-soc-tegra186-dspk-y := tegra186_dspk.o
-snd-soc-tegra210-admaif-y := tegra210_admaif.o
+snd-soc-tegra210-admaif-y := tegra210_admaif.o tegra_isomgr_bw.o
I don't understand why this had to be tacked on like this? Why do we
need exported symbols for something that looks otherwise very specific
to ADMAIF? Will this ever be used outside of the ADMAIF driver? If not
this should just be moved into tegra210_admaif.c and then there's no
need for the EXPORT_SYMBOL() either.
Thanks for pointing, will send a separate patch to fix this.
Thierry
