Hi Dima, kernel test robot noticed the following build warnings: [auto build test WARNING on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Dima-Volkovsk/Staging-nvec-Fix-pm_power_off-reset-condition-in-tegra_nvec_remove/20250210-041929 base: staging/staging-testing patch link: https://lore.kernel.org/r/20250209201752.66313-1-s0ldw3ll%40gmail.com patch subject: [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec_remove config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20250210/202502102138.1CqFj1nV-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250210/202502102138.1CqFj1nV-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202502102138.1CqFj1nV-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/staging/nvec/nvec.c: In function 'tegra_nvec_remove': >> drivers/staging/nvec/nvec.c:908:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 908 | if (pm_power_off = nvec_power_off) | ^~~~~~~~~~~~ vim +908 drivers/staging/nvec/nvec.c 896 897 static void tegra_nvec_remove(struct platform_device *pdev) 898 { 899 struct nvec_chip *nvec = platform_get_drvdata(pdev); 900 901 nvec_toggle_global_events(nvec, false); 902 mfd_remove_devices(nvec->dev); 903 nvec_unregister_notifier(nvec, &nvec->nvec_status_notifier); 904 cancel_work_sync(&nvec->rx_work); 905 cancel_work_sync(&nvec->tx_work); 906 907 /* only reset pm_power_off if it's our handler */ > 908 if (pm_power_off = nvec_power_off) 909 pm_power_off = NULL; 910 } 911 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
