Re: [PATCH v3] mailbox: tegra-hsp: Clear mailbox before using message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 02, 2024 at 03:35:59PM +0530, Kartik Rajput wrote:
> From: Pekka Pessi <ppessi@xxxxxxxxxx>
> 
> The Tegra RCE (Camera) driver expects the mailbox to be empty before
> processing the IVC messages. On RT kernel, the threads processing the
> IVC messages (which are invoked after `mbox_chan_received_data()` is
> called) may be on a different CPU or running with a higher priority
> than the HSP interrupt handler thread. This can cause it to act on the
> message before the mailbox gets cleared in the HSP interrupt handler
> resulting in a loss of IVC notification.
> 
> Fix this by clearing the mailbox data register before calling
> `mbox_chan_received_data()`.
> 
> Fixes: 8f585d14030d ("mailbox: tegra-hsp: Add tegra_hsp_sm_ops")
> Fixes: 74c20dd0f892 ("mailbox: tegra-hsp: Add 128-bit shared mailbox support")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Pekka Pessi <ppessi@xxxxxxxxxx>
> Signed-off-by: Kartik Rajput <kkartik@xxxxxxxxxx>
> ---
> v2 -> v3:
> 	* Updated commit description.
> v1 -> v2:
> 	* Added "Fixes:" tag in the commit message.
> 	* Made similar change for 128-bit shared mailboxes.
> ---
>  drivers/mailbox/tegra-hsp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux