Re: [PATCH v2] mailbox: tegra-hsp: Clear mailbox before using message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 28, 2024 at 02:29:30PM +0530, Kartik Rajput wrote:
> From: Pekka Pessi <ppessi@xxxxxxxxxx>
> 
> Some clients depend on mailbox being empty before processing the
> message. On RT kernel, the thread processing the message may be on
> different CPU or running with higher priority than the interrupt
> handler thread and they may act on the message before mailbox is
> emptied.
> 
> Fixes: 8f585d14030d ("mailbox: tegra-hsp: Add tegra_hsp_sm_ops")
> Fixes: 74c20dd0f892 ("mailbox: tegra-hsp: Add 128-bit shared mailbox support")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Pekka Pessi <ppessi@xxxxxxxxxx>
> Signed-off-by: Kartik Rajput <kkartik@xxxxxxxxxx>
> ---
> v1 -> v2:
> 	* Added "Fixes:" tag in the commit message.
> 	* Made similar change for 128-bit shared mailboxes.
> ---
>  drivers/mailbox/tegra-hsp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Do we know what exactly "some clients" means? I know that TCU uses this
shared mailbox and sometimes it does go into a weird state where it can
loose characters, so I wonder if that's one case that would be fixed by
this.

Not strictly a requirement, but it would be good if we can give a good
description of a case where this helps.

Thierry

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux