Re: [PATCH] mailbox: Switch back to struct platform_driver::remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 19, 2024 at 5:17 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/mailbox to use .remove(),
> with the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> Make a few indentions consistent while touching these struct
> initializers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Hello,
>
> I did a single patch for all of drivers/mailbox. While I usually prefer
> to do one logical change per patch, this seems to be overengineering
> here as the individual changes are really trivial and shouldn't be much
> in the way for stable backports. But I'll happily split the patch if you
> prefer it split.
>
> This is based on today's next, if conflicts arise when you apply it at
> some later time and don't want to resolve them, feel free to just drop
> the changes to the conflicting files. I'll notice and followup at a
> later time then. Or ask me for a fixed resend.
>
> Best regards
> Uwe
>
>  drivers/mailbox/bcm-flexrm-mailbox.c    | 2 +-
>  drivers/mailbox/bcm-pdc-mailbox.c       | 2 +-
>  drivers/mailbox/imx-mailbox.c           | 2 +-
>  drivers/mailbox/mailbox-test.c          | 4 ++--
>  drivers/mailbox/mtk-cmdq-mailbox.c      | 2 +-
>  drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +-
>  drivers/mailbox/qcom-ipcc.c             | 2 +-
>  drivers/mailbox/stm32-ipcc.c            | 2 +-


>  drivers/mailbox/sun6i-msgbox.c          | 4 ++--

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>

>  drivers/mailbox/tegra-hsp.c             | 2 +-
>  drivers/mailbox/zynqmp-ipi-mailbox.c    | 2 +-
>  11 files changed, 13 insertions(+), 13 deletions(-)
>





[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux