On 11/15/24 17:31, Parker Newman wrote:
> From: Parker Newman <pnewman@xxxxxxxxxxxxxxx>
>
> Read the iommu stream id from device tree rather than hard coding to mgbe0.
> Fixes kernel panics when using mgbe controllers other than mgbe0.
It's better to include the full Oops backtrace, possibly decoded.
> Tested with Orin AGX 64GB module on Connect Tech Forge carrier board.
Since this looks like a fix, you should include a suitable 'Fixes' tag
here, and specify the 'net' target tree in the subj prefix.
> @@ -241,6 +243,12 @@ static int tegra_mgbe_probe(struct platform_device *pdev)
> if (IS_ERR(mgbe->xpcs))
> return PTR_ERR(mgbe->xpcs);
>
> + /* get controller's stream id from iommu property in device tree */
> + if (!tegra_dev_iommu_get_stream_id(mgbe->dev, &mgbe->iommu_sid)) {
> + dev_err(mgbe->dev, "failed to get iommu stream id\n");
> + return -EINVAL;
> + }
I *think* it would be better to fallback (possibly with a warning or
notice) to the previous default value when the device tree property is
not available, to avoid regressions.
Thanks,
Paolo
