On 10/1/2024 5:00 AM, Russell King (Oracle) wrote:
> Hi,
>
> On Mon, Sep 30, 2024 at 03:33:41PM -0700, Abhishek Chauhan wrote:
>> +static int aqr111_get_features(struct phy_device *phydev)
>> +{
>> + /* PHY FIXUP */
>> + /* Phy supports Speeds up to 5G with Autoneg though the phy PMA says otherwise */
>> + aqr115c_get_features(phydev);
>> + linkmode_set_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, phydev->supported);
>
> More or less same as the previous. The comment could do with shortening.
> I think for this linkmode_set_bit(), it's not worth using a local
> "supported" variable, so just put phydev->... on the following line to
> avoid the long line.
>
Noted!
> Thanks.
>
