Re: [PATCH] clk: qcom: clk-alpha-pll: Replace divide operator with comparison

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jon,



remainder = do_div(rate, prate);

-    if ((remainder * 2) / prate)
+    if ((remainder * 2) >= prate)
          *l = *l + 1;

*l = rate + (u32)(remainder * 2 >= prate);


The above change does fix this build error for me.

Satya, did you intend this to be a fix? Can we get this into -next?


Yes, I have posted a v2 for this last week, but there are few open comments on that, I'll address them and post V3 including the build error you reported in commit-text.


[v2] https://lore.kernel.org/linux-clk/20240814102005.33493-1-quic_skakitap@xxxxxxxxxxx/


Have you push a V3 yet?


Not yet Jon, I had a query regarding Bjorn's comment where he mentioned the patch wouldn't compile on arm32 target, I am trying to check that with him. Once I get the details I'll make the changes accordingly and post V3.


Thanks,

Satya priya





[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux