Re: [PATCH 7/7] arm64: tegra: Create SKU8 AGX Orin board file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 23, 2024 at 09:49:57PM +0000, Dara Stotland wrote:
> The existing tegra234-p3737-0000+p3701-0000.dtb is compatible
> with the following modules:
> 
> p3701-0000
> p3701-0004
> p3701-0005
> 
> Add support for p3701-0008. Move data that is common to all SKUs
> to a new file called tegra234-p3737-0000+p3701.dtsi. Update
> Makefile and yaml files.
> 
> Signed-off-by: Dara Stotland <dstotland@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/arm/tegra.yaml        |   5 +
>  arch/arm64/boot/dts/nvidia/Makefile           |   1 +
>  .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 544 +----------------
>  .../nvidia/tegra234-p3737-0000+p3701-0008.dts |  11 +
>  .../dts/nvidia/tegra234-p3737-0000+p3701.dtsi | 547 ++++++++++++++++++
>  5 files changed, 566 insertions(+), 542 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dts
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701.dtsi
> 
> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
> index 8fb4923517d0..e108ef0cde86 100644
> --- a/Documentation/devicetree/bindings/arm/tegra.yaml
> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml
> @@ -175,6 +175,11 @@ properties:
>            - const: nvidia,p3737-0000+p3701-0000
>            - const: nvidia,p3701-0000
>            - const: nvidia,tegra234
> +      - description: Jetson AGX Orin Developer Kit with Industrial Module
> +        items:
> +          - const: nvidia,p3737-0000+p3701-0008
> +          - const: nvidia,p3701-0008
> +          - const: nvidia,tegra234
>        - description: NVIDIA IGX Orin Development Kit
>          items:
>            - const: nvidia,p3740-0002+p3701-0008

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run  and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

Best regards,
Krzysztof





[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux