On Fri, Aug 16, 2024 at 03:19:26PM +0100, Will Deacon wrote:
> [...]
>
> > +struct arm_smmu_device *
> > +tegra241_cmdqv_acpi_dsdt_probe(struct arm_smmu_device *smmu,
> > + struct acpi_iort_node *node)
> > +{
> > + struct resource *res;
> > + int irq;
> > +
> > + /* Keep the pointer smmu intact if !res */
> > + res = tegra241_cmdqv_find_acpi_resource(smmu, node, &irq);
> > + if (!res)
> > + return smmu;
>
> Given that this probing code will end up running on non-tegra hardware
> when CONFIG_TEGRA241_CMDQV is enabled, please can you move the common
> part into the main driver?
You mean moving the tegra241_cmdqv_acpi_dsdt_probe() into the main
driver? I think this v11 puts a function call int he header already.
Also, would you please take a look at v12 where there is a little
change cooperating Jason's remarks?
https://lore.kernel.org/linux-iommu/c342c29e51ce3a14c30bd1145a933f415a55b85f.1723754745.git.nicolinc@xxxxxxxxxx/
Thanks!
Nicolin
