On Wed, Aug 14, 2024 at 12:02:57PM +0100, Andi Shyti wrote:
> Hi Breno,
>
> On Wed, Aug 14, 2024 at 01:47:54AM GMT, Breno Leitao wrote:
> > On Tue, Aug 13, 2024 at 11:53:17PM +0100, Andi Shyti wrote:
> > > You don't need to resend the patch. Because the changes are only
> > > in the commit log, I can take care of them.
> >
> > In fact, the changes are in the code itself, see the changelog:
> >
> > * Replaced ACPI_HANDLE() by has_acpi_companion() (Andy Shevchenko)
> > * Expanded the comment before the change (Andy Shevchenko)
>
> I meant no need to send a v3.
>
> > > Besides, you also need:
> > >
> > > Fixes: ede2299f7101 ("i2c: tegra: Support atomic transfers")
> > > Cc: <stable@xxxxxxxxxxxxxxx> # v5.6+
> > >
> > > Can you please check whether this is right?
> >
> > I would say that we probably want to blame the support for ACPI device,
> > which came later than ede2299f7101 ("i2c: tegra: Support atomic
> > transfers").
> >
> > I'd suggest the following:
> >
> > Fixes: bd2fdedbf2ba ("i2c: tegra: Add the ACPI support")
> > CC: <stable@xxxxxxxxxxxxxxx> # v5.17+
>
> Makes sense.
>
> > I am not planning to submit a new patch with these changes, please let
> > me know if you need action on my side.
>
> Not for now, you might need to still support the backports to
> stable as there might be some differences and I can already see
> that it doesn't apply that far back (from 6.1, basically).
Sure, count me on, if you need backports to stable.
Thanks for getting this fixed
--breno
