Re: [PATCH v2 2/2] arm64: tegra: enable same UARTs for Orin NX/Nano

[Jon Hunter <jonathanh@xxxxxxxxxx>]

On 11/07/2024 18:11, Vedant Deshpande wrote:
> This patch ensures that Orin NX and Orin Nano enable an identical
> set of serial ports. UARTA/UARTE will be enabled by adding
> respective nodes to the board dtsi file.
>
> Signed-off-by: Vedant Deshpande <vedantd@xxxxxxxxxx>
> ---
>   .../nvidia/tegra234-p3768-0000+p3767-0000.dts   | 17 -----------------
>   .../dts/nvidia/tegra234-p3768-0000+p3767.dtsi   | 14 ++++++++++++++
>   2 files changed, 14 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts
> index 82a59e33c46c..5dc974bb360c 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts
> @@ -7,24 +7,7 @@ / {
>   	compatible = "nvidia,p3768-0000+p3767-0000", "nvidia,p3767-0000", "nvidia,tegra234";
>   	model = "NVIDIA Jetson Orin NX Engineering Reference Developer Kit";
>   
> -	aliases {
> -		serial1 = &uarta;
> -		serial2 = &uarte;
> -	};
> -
>   	bus@0 {
> -		serial@3100000 {
> -			compatible = "nvidia,tegra194-hsuart";
> -			reset-names = "serial";
> -			status = "okay";
> -		};
> -
> -		serial@3140000 {
> -			compatible = "nvidia,tegra194-hsuart";
> -			reset-names = "serial";
> -			status = "okay";
> -		};
> -
>   		hda@3510000 {
>   			nvidia,model = "NVIDIA Jetson Orin NX HDA";
>   		};
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi
> index 6d64a24fa251..81d4f4f12ab1 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi
> @@ -9,6 +9,8 @@ / {
>   
>   	aliases {
>   		serial0 = &tcu;
> +		serial1 = &uarta;
> +		serial2 = &uarte;
>   	};
>   
>   	chosen {
> @@ -16,6 +18,18 @@ chosen {
>   	};
>   
>   	bus@0 {
> +		serial@3100000 {
> +			compatible = "nvidia,tegra194-hsuart";
> +			reset-names = "serial";
> +			status = "okay";
> +		};
> +
> +		serial@3140000 {
> +			compatible = "nvidia,tegra194-hsuart";
> +			reset-names = "serial";
> +			status = "okay";
> +		};
> +
>   		i2c@3160000 {
>   			status = "okay";
>   

Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks!
Jon

--
nvpublic