On 11/07/24 07:01, Christoph Hellwig wrote:
> On Wed, Jul 10, 2024 at 09:07:37PM +0300, Adrian Hunter wrote:
>> blk_queue_max_segment_size() ensured:
>>
>> if (max_size < PAGE_SIZE)
>> max_size = PAGE_SIZE;
>
> This is a bit misleading, as it also warned about it and papered over it
> with the above as it had no way to return errors. Any everyone seeing
> these problems now ignored the warnings before, probably for years..
Was there a warning, since the message in blk_queue_max_segment_size()
was:
pr_info("%s: set to minimum %u\n", __func__, max_size);
>
> Except for that:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
