On 06/06/2024 09:41, Dan Carpenter wrote:
So the original bug was that rmem_read() is returning positive values
on success instead of zero[1]. That started a discussion about partial
reads which resulted in changing the API to support partial reads[2].
That patchset broke the build. This patchset is trying to fix the
build breakage.
[1]https://lore.kernel.org/all/20240206042408.224138-1-joychakr@xxxxxxxxxx/
[2]https://lore.kernel.org/all/20240510082929.3792559-2-joychakr@xxxxxxxxxx/
The bug in rmem_read() is still not fixed. That needs to be fixed as
a stand alone patch. We can discuss re-writing the API separately.
I agree with Dan, Lets fix the rmem_read and start working on the API
rework in parallel.
Am happy to pick the [1].
--srini
