Mon, May 13, 2024 at 01:59:03PM +0200, Geert Uytterhoeven kirjoitti: > On Sat, May 4, 2024 at 3:14 PM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote: ... > You missed one trivial conversion, presumably because no error handling > and thus no of_node_put() is involved? Nothing is missed. The below is a redundant change. ... > - for_each_child_of_node(np, child) { > + for_each_child_of_node_scoped(np, child) { > if (of_property_count_u32_elems(child, RZN1_PINS_PROP) > 0) > count++; > } > > If you prefer not to include this I prefer this not to be included as it will give a misleading signals to the use of the original API(s). -- With Best Regards, Andy Shevchenko