On Sun, May 12, 2024 at 12:02:21PM -0300, Jason Gunthorpe wrote: > On Fri, Apr 12, 2024 at 08:47:09PM -0700, Nicolin Chen wrote: > > > +/** > > + * struct iommu_vqueue_alloc - ioctl(IOMMU_VQUEUE_ALLOC) > > + * @size: sizeof(struct iommu_vqueue_alloc) > > + * @flags: Must be 0 > > + * @viommu_id: viommu ID to associate the virtual queue with > > + * @out_vqueue_id: The ID of the new virtual queue > > + * @data_type: One of enum iommu_vqueue_data_type > > + * @data_len: Length of the type specific data > > + * @data_uptr: User pointer to the type specific data > > + * > > + * Allocate an virtual queue object for driver-specific HW-accelerated queue > > + */ > > + > > +struct iommu_vqueue_alloc { > > + __u32 size; > > + __u32 flags; > > + __u32 viommu_id; > > + __u32 out_vqueue_id; > > + __u32 data_type; > > + __u32 data_len; > > + __aligned_u64 data_uptr; > > Some of the iommus will want an IPA here not a user pointer. I think > it is fine API wise, we'd just add a flag to indicate data_uptr is an > IPA. Ack. Nicolin